Skip to content

Fix postgresdatabase default location#330

Closed
rnestler wants to merge 1 commit intoninech:mainfrom
rnestler:fix-postgresdatabase-default-location
Closed

Fix postgresdatabase default location#330
rnestler wants to merge 1 commit intoninech:mainfrom
rnestler:fix-postgresdatabase-default-location

Conversation

@rnestler
Copy link
Copy Markdown
Contributor

@rnestler rnestler commented Jan 12, 2026

By using default instead of placeholder we actually get it as the default.

@rnestler
Fix postgresdatabase default location
021505f 
By using default instead of placeholder we actually get it as the
default.
@thde
Copy link
Copy Markdown
Member

thde commented Jan 12, 2026

Thank you @rnestler, sorry I didn't realize you opened this PR. We already fixed the issue in #331. We prefer using placeholder, so the API uses its configured default and we won't hard-code it here in nctl.

@thde thde closed this Jan 12, 2026
@rnestler
Copy link
Copy Markdown
Contributor Author

rnestler commented Jan 12, 2026

We prefer using placeholder, so the API uses its configured default and we won't hard-code it here in nctl.

Then were does postgresdatabase_location_default come from if not from the code?

@rnestler
Copy link
Copy Markdown
Contributor Author

rnestler commented Jan 12, 2026 •
edited
Loading

Also: The code uses default:"nine-es34" in create/cloudvm.go`. Should this be fixed or is it a special case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rnestler @thde